History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: LM-120
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Dafydd Harries
Reporter: Owen Taylor
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Loudmouth

Protect EAI_NODATA with #ifdef

Created: 21/Feb/08 08:00 PM   Updated: 24/Sep/08 03:06 PM
Component/s: None
Affects Version/s: 1.3.3
Fix Version/s: 1.3.4

File Attachments: 1. Text File loudmouth-1.3.3-eai-nodata.patch (0.8 kb)



 Description  « Hide
A recent change to GNU libc changes the EAI_NODATA constant in netdb.h to only be
defined when _GNU_SOURCE is defined.

A google for "loudmouth EAI_NODATA" indicates that EAI_NODATA is also problematical
on FreeBSD.

I'm attaching a patch that protects the usage of EAI_NODATA with an ifdef ... I think this
is preferable to the sledgehammer of _GNU_SOURCE; while GNU libc can apparently
still return this error value, using the default message in this rare corner case should not
be a problem.



 All   Comments   Change History      Sort Order:
Mikael Hallendal - [25/Feb/08 10:59 PM ]
Thanks a lot for the patch Owen. I've committed this to my tree.

ID: f69a4fa083f20c0a382ba0d03dd8fc45e5f20b62